Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terragrunt parsing #409

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fix terragrunt parsing #409

merged 2 commits into from
Apr 26, 2024

Conversation

MatrixCrawler
Copy link
Collaborator

This will fix #401

  • removed diagnostic.hasError check as it is expected to have an error every time something is present that we are not looking explicitly for.
  • introduced test if a terraform_version_constraint can be found in hcl file.

@MatrixCrawler
* removed diagnostic.hasError check as it is expected to have an erro…
88f6b33 
…r every time something is present that we are not looking explicitly for.

* introduced test if a terraform_version_constraint can be found in hcl file.
@MatrixCrawler MatrixCrawler linked an issue Apr 25, 2024 that may be closed by this pull request
Any content in terragrunt.hcl other than "terraform_version_constraint" causes tfswitch to error #401
Closed
@MatrixCrawler MatrixCrawler added the bug Something isn't working label Apr 25, 2024
@MatrixCrawler MatrixCrawler added this to the Release 1.1.1 milestone Apr 25, 2024
@MatrixCrawler MatrixCrawler mentioned this pull request Apr 26, 2024
Closed
warrensbox
warrensbox approved these changes Apr 26, 2024
View reviewed changes
Copy link
Owner

@warrensbox warrensbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this code and looks like everything is working as the issue pointed out.

@MatrixCrawler MatrixCrawler merged commit 6e0b171 into master Apr 26, 2024
3 checks passed
@MatrixCrawler MatrixCrawler deleted the 401-any-content-in-terragrunthcl-other-than-terraform_version_constraint-causes-tfswitch-to-error branch April 26, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrensbox warrensbox warrensbox approved these changes

@jukie jukie Awaiting requested review from jukie jukie is a code owner

@crablab crablab Awaiting requested review from crablab crablab is a code owner

@MatthewJohn MatthewJohn Awaiting requested review from MatthewJohn MatthewJohn is a code owner

@yermulnik yermulnik Awaiting requested review from yermulnik yermulnik is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.1.1
Development

Successfully merging this pull request may close these issues.

Any content in terragrunt.hcl other than "terraform_version_constraint" causes tfswitch to error
3 participants
@MatrixCrawler @yermulnik @warrensbox