-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More AC60 fields and AC70 support #79
base: main
Are you sure you want to change the base?
Conversation
bxm6306
commented
May 15, 2023
- Added 30+ more data fields for the AC60 and B80 devices
- Removed unused power generation fields based on AC60 test results
Added 30+ more data fields for the AC60
Sample data extraction using an AC60 prototype. ==2023-05-15 00:30:55.643513 -0400== |
@bxm6306 I've enabled the automated checks, and it looks like you have a bunch of places where you didn't put a space between the comma and the next value. Those will also need to be addressed before this can be merged. You can see this by clicking on the "Details" button next to the failing "Build distribution / deploy (pull_request)" check. Also, you might want to add this section to the bottom of the @property
def writable_ranges(self) -> List[range]:
return [range(2000, 2022)] |
Adding missing spaces to structure definitions and added writable address range.
Corrected additional style warnings
Minor field name updates to match MQTT field definitions and added missing address ranges to polling_commands.
Added the following new MQTT fields: DC USB Output Power DC 12V Output Power AC Input Current AC Eco DC Eco Grid Enhancement Mode Estimated Charge/Run Time Changed the following MQTT fields to be labeled as normal instead of advanced fields: AC Input Voltage AC Input Frequency
Split out estimated time field because the AC60 reports this field in minutes while the AC70 reports it in hours with 1 decimal place.
Renamed estimated_time to estimated_time_min to reflect the correct unit of measurement.
I've added AC70 support to this pull request, 99% of the code was identical to the AC60. |
This is GREAT! Thanks heaps for everyone's efforts! |
What else is needed for this? Would be nice to have ac60/b80 more supported. |
Action by @warhammerkid to review the requested changes in the branch. It seems he's currently MIA and I'm not sure if anyone else can assist with merging the changes. |
In the interim, I setup a build for home assistant using bxm6306's fork incase its helpful for anyone who is in the same boat as I am waiting for this to get merged -- https://github.com/ZachGoldberg/bluetti2mqtt |
Hey, I made an more advanced fork of the bluetti_mqtt library. I incorporated so far most of the pull requests from all the stuff so far. I would be happy if you would give it a try in your HA addon. That way we could achieve a new addon that would work also for newer devices. I know that this is less ideal then the merge into the main branch of this repo, but at least we could provide sth more working. The URL to my fork is: https://github.com/ftrueck/bluetti_mqtt/ If sth is missing feel free to open a issue in my fork. |
Friendly nudge @warhammerkid |