Refactoring towards 2.0 #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setup json scanning to allow for arrays as the parent type * rather than assuming an object, just validate any json value * keep as close to the original as possible * Since all the validation comes within val we don't need to increment off. Initial tests seemed to work * Fix formatting issue
* Changes to strncpy() to remove compile warnings with Ubuntu 20.04 LTS. Source is controlled, so no need for strncpy() Tested with Nginx-1.18.0 and NAXSI-0.56 * Fix. Strcpy would add a terminating null character. Changes to memcpy()
…ile opening. (#507) * Added CIDR to whitelist (IP and CIDRs are allowed). * Bug while sometimes opening the file and sometims not (!). Weird NGINX behavior.
* Bug with WhitelistFile. If it wasn't there and specified or/not specified in Confing, Naxsi would segfault. * Tests for WhitelistFile option
The content should be well formed JSON and it will make NAXSI not complain about Unknown Format. Can help many other users.
wargio
force-pushed
the
refactoring-1.4
branch
3 times, most recently
from
6460ec4
to
d0a1b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this branch is to rework over naxsi source code, rewrite it and provide libnaxsi for development and an apache module.