multiple fixes #86
Merged
multiple fixes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to Rust 1.79.0. Also, make sure all the required targets are installed. Signed-off-by: Flavio Castelli <[email protected]>
Prior to this commit, the GH actions installed the rust toolchain using the now archived `actions-rs/toolchain`. On top of that, the actions were installing latest `stable` release of Rust, overriding what was specified inside of our `rust-toolchain.toml` file. That lead to different behaviour locally and inside of the runners. For example, that caused the automated release of `wasmtime-provider` 1.19.0 to fail because of different clippy rules between the local development and the runners. GitHub runners have `rustup` installed by default. That, together with our `rust-toolchain.toml` file is enough to get the right version of Rust automatically installed. Signed-off-by: Flavio Castelli <[email protected]>
The old `wasm32-wasi` target has been deprecated and is going to be completely replaced by `wasm32-wasip1`. See [this blog post](https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html). This commit ensures we use the right WASI target. As a final note, the `.wasm` file part of the commit is the same program rebuilt with the new target. Signed-off-by: Flavio Castelli <[email protected]>
Address all the linter warnings raised by latest version of clippy Signed-off-by: Flavio Castelli <[email protected]>
pkedy
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automated release of
wasmtime-providerv1.19.0 failed because of a discrepancy between the version of Rust used locally and on the remote branch.This PR contains several commits that bring more stability and consistency to the project.
Detailed changes
Update to latest stable release of Rust
Update to Rust 1.79.0. Also, make sure all the required targets are installed.
automation: uniform handling of Rust installation
Prior to this commit, the GH actions installed the rust toolchain using the now archived
actions-rs/toolchain.On top of that, the actions were installing latest
stablerelease of Rust, overriding what was specified inside of ourrust-toolchain.tomlfile. That lead to different behaviour locally and inside of the runners.For example, that caused the automated release of
wasmtime-provider1.19.0 to fail because of different clippy rules between the local development and the runners.GitHub runners have
rustupinstalled by default. That, together with ourrust-toolchain.tomlfile is enough to get the right version of Rust automatically installed.deps: update Rust's WASI target
The old
wasm32-wasitarget has been deprecated and is going to be completely replaced bywasm32-wasip1.See this blog post.
This commit ensures we use the right WASI target.
As a final note, the
.wasmfile part of the commit is the same program rebuilt with the new target.fixes: address linter warnings
Address all the linter warnings raised by latest version of clippy
What's next
Once this PR is merged, I'll tag a new release of
wasmtime-provider: v1.19.1.