Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to UIImageView #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Alex601t
Copy link

@Alex601t Alex601t commented Nov 17, 2017

@wangjwchn hey! I'm back 😎. So, I have a good news for us:
Testing on (iPhone 6s, 11.1, Xcode 9.1 (9B55))
Old implementation: https://puu.sh/ynWBq/affb71ab10.png
After small changes: https://puu.sh/ynWBT/8ecccbad27.png
Resource: https://wangjwchn.github.io/image/view.gif

@wangjwchn Could you test as you wish and review code ?

Refactor:

  1. Change layer contects setting to image setting;
  2. Remove decode image function;
  3. Time fired function;
  4. Add types to variables.

601t added 2 commits November 17, 2017 17:19
1. Change layer contects setting to image setting;
2. Remove decode image function;
3. Time fired function;
4. Add types to variables.
@Alex601t Alex601t mentioned this pull request Nov 17, 2017
@gmogames
Copy link

gmogames commented Mar 2, 2018

@Alex601t have you tested this?

I would look at the code again and remove force unwraps, rename the method image(from:at) to something different, and would check the prepareCache function since the calling to that function is not correct.
Also, I would update the readme and the demo comments up in the code to match the changes.

Yuya-Tominaga-VIT pushed a commit to GroupVantageApps/AImage that referenced this pull request Apr 9, 2020
Yuya-Tominaga-VIT pushed a commit to GroupVantageApps/AImage that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants