Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing-response-components, add misplaced-response-components #18

Conversation

aj-stein-gsa
Copy link

@aj-stein-gsa aj-stein-gsa commented Dec 4, 2024

Committer Notes

Merging this change fixes GSA#939.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@aj-stein-gsa aj-stein-gsa force-pushed the 939-fix-missing-response-components branch from 218ee65 to 4a737fb Compare December 4, 2024 23:07
Gabeblis and others added 6 commits December 5, 2024 10:21
* deprecate ssp-all-valid

* Update src/validations/constraints/content/ssp-has-network-architecture-diagram-link-href-target-VALID-1.xml

Co-authored-by: A.J. Stein <[email protected]>

* Update src/validations/constraints/content/ssp-has-authorization-boundary-diagram-link-href-target-VALID-1.xml

Co-authored-by: A.J. Stein <[email protected]>

* Update src/validations/constraints/content/ssp-has-data-flow-diagram-link-href-target-VALID-1.xml

Co-authored-by: A.J. Stein <[email protected]>

* Update src/validations/constraints/content/ssp-has-network-architecture-diagram-link-href-target-VALID-1.xml

Co-authored-by: A.J. Stein <[email protected]>

* Update fedramp-ssp-example.oscal.xml

---------

Co-authored-by: A.J. Stein <[email protected]>
…implementation context (GSA#966)

Remove duplicate constraint and fix system-implementation context
@aj-stein-gsa aj-stein-gsa force-pushed the 939-fix-missing-response-components branch from 4a737fb to e3eb37a Compare December 5, 2024 20:10
@aj-stein-gsa
Copy link
Author

I was so late to the party and people merged GSA#960 before I could get more reviews. I will go for take three, third time's a charm, back on the upstream repo with a separate PR. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants