Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Weave Trace image to wsm #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add Weave Trace image to wsm #28

wants to merge 1 commit into from

Conversation

velotioaastha
Copy link
Contributor

Add the weave trace image to the wsm subcommands where all other images are used

@velotioaastha velotioaastha linked an issue Nov 27, 2024 that may be closed by this pull request
Add Weave Trace image to wsm #27
Open
theishshah
theishshah approved these changes Nov 27, 2024
View reviewed changes
Copy link

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would like to get another set of eyes to confirm that we want "install": true by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theishshah theishshah theishshah approved these changes

@danielpanzella danielpanzella Awaiting requested review from danielpanzella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Weave Trace image to wsm
2 participants
@velotioaastha @theishshah