feat(weave): Scorer.score -> async in LLMScorer #3056
+107
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=e075deb27b1203791658a871ed35e2ba54bd1814 |
|
This changes the default behavior of the LLM-powered scorers to be async by default. I think this is a reasonable logic. Happy to discuss with you @andrewtruong how to test this correctly =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors scorer classes and related utilities to use asynchronous operations, enhancing performance and scalability. It updates LLM clients, converts synchronous methods to asynchronous ones, modifies unit tests for async compatibility, and updates the documentation accordingly.
Solves #3051