Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): change dataset link #3040

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

jamie-rasmussen
Copy link
Collaborator

Description

Internal Slack: https://weightsandbiases.slack.com/archives/C03BSTEBD7F/p1732142002439589

Continuing on path of removing the @mui/icons-material dependency. Per discussion with design, changing to show a link with truncated id instead of updating the icon.

Before:
Screenshot 2024-11-21 at 10 45 25 AM

After:
Screenshot 2024-11-21 at 10 41 48 AM

Testing

How was this PR tested?

@circle-job-mirror
Copy link

circle-job-mirror bot commented Nov 21, 2024

@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review November 21, 2024 21:32
@jamie-rasmussen jamie-rasmussen requested review from a team as code owners November 21, 2024 21:32
@jamie-rasmussen jamie-rasmussen merged commit 4e4f647 into master Nov 21, 2024
115 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/remove-link-icon branch November 21, 2024 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants