New metriclist for voo #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version reports about 7 metrics (6+1), i.e. 'Downstream Power','Downstream SNR','Frequency','Octets','Corrected','Uncorrectable','Upstream Power'. v0.1 only had 6 metrics.
This version has properly labelled metrics (v0.1 had the values stuck in "random" metrics).
This version protects itself against the router reporting a count of zero (e.g. octets) for channel zero (sic).
Check the readme for some weaknesses. For instance, the filtering is flaky. IF some chart displays 7 days, it might show 20 channels; while another chart displaying 1 day might only show 16 channels. This scenario is probably not present on the original target modem; and the code is probably imperectly coping. For instance, the legends are different in differnt graphs which is not great (e.g. channel 22 in the chart that has 20 channels, vs the graph that has 16 channels, including 22).