Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement AWS instance auth #816

Merged
merged 8 commits into from
Nov 7, 2024
Merged

implement AWS instance auth #816

merged 8 commits into from
Nov 7, 2024

Conversation

SuperBatata
Copy link
Contributor

Description

Provide a clear and concise description of the changes made in this pull request:

Type of Change

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality

Checklist

  • code cleanup and self-review
  • unit + e2e test coverage
  • documentation updated accordingly

Breaking

  • -

Copy link

sonarcloud bot commented Nov 5, 2024

@SuperBatata SuperBatata requested a review from waltkb November 5, 2024 16:58
@SuperBatata SuperBatata self-assigned this Nov 5, 2024
@SuperBatata SuperBatata marked this pull request as ready for review November 5, 2024 16:58
Copy link
Contributor

@waltkb waltkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok; but please check the timeout

@philpotisk philpotisk merged commit c37f819 into main Nov 7, 2024
4 checks passed
@philpotisk philpotisk deleted the refactor-aws-kms branch November 7, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants