Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved yield problem #6

Merged
merged 2 commits into from
Jan 10, 2017
Merged

Resolved yield problem #6

merged 2 commits into from
Jan 10, 2017

Conversation

ajile
Copy link

@ajile ajile commented Dec 19, 2016

No description provided.

@ajile ajile mentioned this pull request Dec 19, 2016
Merged
ivandokov
ivandokov reviewed Dec 19, 2016
View reviewed changes
Copy link

@ivandokov ivandokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think presenter-body is not the perfect component name for the case. dialog-body sounds better and is much more self explanatory.

@ajile
Copy link
Author

ajile commented Dec 19, 2016 •
edited
Loading

Hmmm, maybe you’re right. I picked that name in accordance with a main component name. Now i think that name of the main component (presenter) itself is not explanatory name and maybe we should rename it to dialog-base (or something like that) as well..

@waleedq
Copy link
Owner

waleedq commented Dec 27, 2016

Hello, sorry for being late, i was busy the past couple of days i will test this PR the next couple of days.

@waleedq waleedq merged commit 3b08911 into waleedq:master Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivandokov ivandokov ivandokov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajile @waleedq @ivandokov