refactor(networking): wait for all futures together in connectToNodes #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
jm-clius
approved these changes
Jan 9, 2023
alrevuelta
force-pushed
the
connect-await-together
branch
from
44a8d88
to
cc87f30
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dialPeerindividually, this pr triggers all dials, stores the futures in an array and then waits for the futures to be completed. This substantially decreases the time it takes for a nwaku node to reach a reasonable number of connections.connectToNodesI could verify that the time it tool to connect to all of them decreased from 43/44 seconds to 4/5 seconds. Note that it was tested against our fleets