fix: don't dial discovered peers if have already been attempted dial

[danisharora099]

Problem

When we discover new peers, a dial attempt is fired. If this discovery is emitted multiple times, it currently does not check if there is an active dial attempt for this peer, or if we've already tried to dial this peer before.

This is unwanted behaviour as we might trigger dial attempts for peer that have already been attempted.

Solution

Do not dial peers if they have already been attempted dial before (will be handled with reconnections), or if they have a dial attempt in progress

Notes

• this PR also adds a test for the same use case
• related to multiple connections opened for the same peer #1459
• reference: multiple connections opened for the same peer #1459 (comment)
• should be merged after chore: refactor ConnectionManager for readability & maintainability #1658

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
Waku core	83.87 KB (+0.08% 🔺)	1.7 s (+0.08% 🔺)	1.7 s (-35.69% 🔽)	3.4 s
Waku Simple Light Node	264.11 KB (+0.03% 🔺)	5.3 s (+0.03% 🔺)	4 s (-5.2% 🔽)	9.3 s
ECIES encryption	79.48 KB (0%)	1.6 s (0%)	2.8 s (-2.15% 🔽)	4.4 s
Symmetric encryption	79.49 KB (0%)	1.6 s (0%)	2.8 s (+2.73% 🔺)	4.4 s
DNS discovery	111.24 KB (0%)	2.3 s (0%)	3.1 s (-13.53% 🔽)	5.3 s
Privacy preserving protocols	131.8 KB (0%)	2.7 s (0%)	3.7 s (-7.6% 🔽)	6.3 s
Light protocols	81.5 KB (0%)	1.7 s (0%)	1.6 s (-36.58% 🔽)	3.2 s
History retrieval protocols	80.55 KB (0%)	1.7 s (0%)	1.8 s (-2.43% 🔽)	3.4 s
Deterministic Message Hashing	5.65 KB (0%)	113 ms (0%)	453 ms (+124.31% 🔺)	566 ms

[weboko]

I see it was before here - but how do you think - is it possible to avoid?

[danisharora099]

Moved this out of the loop, right before we check the call count.
We need to add a little delay before we check for the call count to ensure the async operations within have completed.

Also refactored the test to check for callCount to be >= discovery events fired instead of callCount === events emitted as attemptDial should take care of the redundant cases that may arise from dialPeerStorePeers