feat: enable pinging connected peers by default #1647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have been seeing some problems re disconnection of js-waku from service nodes after ~10 mins mark when there is no activity on the peers.
We do have the ability for users to keep pinging this needs, to maintain the connection open. However, this is set disabled by default.
Solution
Enable pinging service nodes we're connected to, by default, at an interval of 5 minutes.
Notes