Relax dependencies on dry-* gems #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a duplicate of #46 which also add zeitwerk loading |
waiting-for-dev
requested changes
Jan 22, 2023
lib/warden/jwt_auth/version.rb
Outdated
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| module Warden | |||
| module JWTAuth | |||
| VERSION = '0.7.0' | |||
| VERSION = '0.7.1' | |||
There was a problem hiding this comment.
Can we revert this change? It's a change not related to what the commit describes.
There was a problem hiding this comment.
Good point. Fixed!
|
Many thanks for your collaboration. I'd just to bump the version after merging this. |
dry-auto_inject and dry-configurable have recently released 1.x versions that are for the purposes of this gem compatible with the 0.x versions already supported. This commit relaxes version constraints so we can use these newer gems.
Thank you for the quick response! |
waiting-for-dev
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi! First of all, thank you for your work on this repo, it's super appreciated!
We've been updating some of our dependencies and found that the current constraints for the
dry-auto_injectanddry-configurablegems are stricter then they need to be. Both gems recently released1.xversions, and those to seem to work great. This PR relaxes those constraints to make warden-jwt_auth compatible with these newer versions.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):I have added automated tests to cover my changes.I have attached screenshots to demo visual changes.I have opened a PR to update the guides.I have updated the README to account for my changes.