Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devise-jwt.gemspec to make it compatible with devise 5 alpha #275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaadow
Copy link

@chaadow chaadow commented Aug 16, 2024

Summary

Devise started the development of devise 5 in its alpha phase. I believe it's safe to have a less strict on the dependency's version

This is also so that people using devise's main branch can still use devise-jwt

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

Devise started the development of devise 5 in its alpha phase. I believe it's safe to have a less strict on the dependency's version
@chaadow chaadow changed the title Update devise-jwt.gemspec Update devise-jwt.gemspec to make it compatible with devise 5 alpha Aug 16, 2024
@waiting-for-dev
Copy link
Owner

Hey @chaadow, I think that would be risky and the appropriate thing to do would be maintaining a branch with support for devise 5 in the meantime. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants