Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

達成基準 1.4.12 テキストの間隔 : 「注記」の翻訳 #58

Merged
merged 6 commits into from
Feb 1, 2024

Conversation

caztcha
Copy link
Contributor

@caztcha caztcha commented Jan 22, 2024

達成基準 1.4.12 テキストの間隔
で新たに追加された注記を翻訳しました。

達成基準 1.4.8 視覚的提示
の注記に近いないようなので、先行してマージされた PR #46 に合わせて、59e81611e8a017 で修正を加えています。

@caztcha caztcha requested a review from momdo January 22, 2024 08:34
Copy link
Member

@momdo momdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caztcha

レビューしましたのでご確認ください。

guidelines/index.html Outdated Show resolved Hide resolved
@momdo momdo added the WCAG22 WCAG 2.2の翻訳 label Jan 23, 2024
@momdo momdo linked an issue Jan 23, 2024 that may be closed by this pull request
Co-authored-by: Momdo Nakamura <[email protected]>
@caztcha
Copy link
Contributor Author

caztcha commented Jan 23, 2024

@momdo レビューありがとうございました!修正提案、確認のうえコミットしました。

@caztcha caztcha requested a review from momdo January 23, 2024 04:41
@momdo momdo requested a review from bakera January 23, 2024 05:39
@momdo
Copy link
Member

momdo commented Jan 23, 2024

@caztcha
ありがとうございました。
@bakera
ご確認ください。

Copy link
Contributor

@bakera bakera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいところですがコメントしました。感覚的なものかも……?

guidelines/index.html Outdated Show resolved Hide resolved
guidelines/index.html Outdated Show resolved Hide resolved
caztcha and others added 2 commits February 1, 2024 17:47
Co-authored-by: MINAZUKI, Bakera <[email protected]>
Co-authored-by: MINAZUKI, Bakera <[email protected]>
@caztcha
Copy link
Contributor Author

caztcha commented Feb 1, 2024

@bakera 訳していて若干もやっとしていたところを、鋭く突いていただき、ありがとうございます!いずれのご指摘も、いただいた修正提案で異論ありませんので、コミットしました。

@caztcha caztcha requested a review from bakera February 1, 2024 08:52
Copy link
Contributor

@bakera bakera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。よさそうです。

@bakera bakera merged commit 93e83f7 into main Feb 1, 2024
@momdo momdo deleted the tsuchiya-edit-issue9 branch March 1, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WCAG22 WCAG 2.2の翻訳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WCAG 2.2:達成基準 1.4.12 テキストの間隔 注記
3 participants