Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

達成方法集 G192の翻訳 #1270

Merged
merged 3 commits into from
Jan 22, 2022
Merged

達成方法集 G192の翻訳 #1270

merged 3 commits into from
Jan 22, 2022

Conversation

caztcha
Copy link
Contributor

@caztcha caztcha commented Dec 17, 2021

プルリクエスト作成時の確認事項

コメント

@caztcha caztcha self-assigned this Dec 17, 2021
@caztcha
Copy link
Contributor Author

caztcha commented Dec 17, 2021

@momdo 翻訳作業を実施しました。
2.0 と 2.1 との間で、特に差分はありませんでした。

@caztcha caztcha mentioned this pull request Dec 17, 2021
Closed
@caztcha caztcha requested a review from momdo December 17, 2021 02:02
@momdo momdo added the 達成方法集-201910 達成方法集（2019年10月版） label Dec 24, 2021
@momdo momdo linked an issue Dec 24, 2021 that may be closed by this pull request
達成方法集 G192の翻訳 #524
Closed
momdo
momdo requested changes Dec 24, 2021
View reviewed changes
Copy link
Member

@momdo momdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caztcha
作業ありがとうございます。1点コメントしましたのでご確認ください。

techniques/general/G192.html Outdated
@@ -2,111 +2,100 @@
<html lang="ja">
<head>
<meta charset="UTF-8" />
<title>G192: Fully conforming to specifications</title>
<title>G192: 仕様に完全に準拠する</title>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conform、準拠というより適合なのでは…？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

そのとおりですね。別途修正します。

@caztcha
Copy link
Contributor Author

caztcha commented Jan 13, 2022

@momdo レビューありがとうございます。conform to の訳語、「準拠」→「適合」に修正しました。

また、念のため G192 のタイトルをリンクラベルとして使用しているページがないかを、/techniques/ フォルダ以下を対象にマルチファイル検索したところ、該当箇所はありませんでした。

@caztcha caztcha requested a review from momdo January 13, 2022 09:15
momdo
momdo approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@momdo momdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caztcha
確認ありがとうございます。マージします。

@momdo momdo merged commit 1b9aaa0 into master Jan 22, 2022
@momdo momdo deleted the tsuchiya-edit-issue524 branch January 22, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momdo momdo momdo approved these changes

Assignees

@caztcha caztcha

Labels
達成方法集-201910 達成方法集（2019年10月版）
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

達成方法集 G192の翻訳
2 participants
@caztcha @momdo