-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disclosure (Show/Hide)の日本語化 #146
Open
tsmd
wants to merge
10
commits into
waic-main
Choose a base branch
from
disclosure-ja
base: waic-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for waic-apg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
caztcha
reviewed
Jun 3, 2024
caztcha
reviewed
Jun 3, 2024
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-image-description.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-image-description.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
caztcha
reviewed
Jun 3, 2024
caztcha
reviewed
Jun 3, 2024
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
caztcha
reviewed
Jun 3, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
@tsmd 翻訳ありがとうございます!ひととおりレビューいたしましたので、ご確認いただけますと幸いです。 |
tsmd
commented
Jun 16, 2024
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
content/patterns/disclosure/examples/disclosure-navigation-hybrid.html
Outdated
Show resolved
Hide resolved
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
content/patterns/disclosure/examples/disclosure-navigation.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Kazuhiko Tsuchiya <[email protected]>
@caztcha |
…rid.html Co-authored-by: Shimada Takayuki <[email protected]>
Co-authored-by: Shimada Takayuki <[email protected]>
@tsmd レビューのご確認ならびに修正提案、ありがとうございます。2点、確認し、問題なさそうでしたので、コミットしました。 |
@bakera |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連Issue
closes #92
レビュワーに見てもらいたい箇所
https://deploy-preview-146--waic-apg.netlify.app/patterns/disclosure/disclosure-pattern.html
https://deploy-preview-146--waic-apg.netlify.app/patterns/disclosure/examples/disclosure-image-description
https://deploy-preview-146--waic-apg.netlify.app/patterns/disclosure/examples/disclosure-faq
https://deploy-preview-146--waic-apg.netlify.app/patterns/disclosure/examples/disclosure-navigation
https://deploy-preview-146--waic-apg.netlify.app/patterns/disclosure/examples/disclosure-navigation-hybrid
翻訳チェックリスト
html
要素にlang="ja"
属性を付与するh1
要素の直下に翻訳元リビジョンを記載する