Draftail updates, refactors, bug fixes #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
commented
Jan 26, 2018
| @include nice-padding; | ||
| } | ||
|
|
||
| .full .Draftail-Toolbar { | ||
| @include nice-margin; | ||
| } | ||
|
|
||
| .title .Draftail-Editor .public-DraftEditor-content { | ||
| .title .Draftail-Editor .public-DraftEditor-content, | ||
| .title .Draftail-Editor .public-DraftEditorPlaceholder-root { |
There was a problem hiding this comment.
This and above – placeholder alignment issue.
| @@ -35,6 +35,7 @@ | |||
|
|
|||
| &__img { | |||
| @include invalid-image-fallback; | |||
| display: block; | |||
There was a problem hiding this comment.
MediaBlock border issue
2 tasks
gasman
approved these changes
Jan 26, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the following tasks from #4136:
iOS Safarifull-width fieldsdata-attribute to Hallo editor to define documented integration point for plugins.The
draftjs-filterstransitive dependency update also fixes a nasty Draft.js design choice, which you can read about here: facebookarchive/draft-js#504Edit: see #4229 for next steps.