Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.2 Support #813

Merged
merged 21 commits into from
Aug 22, 2024
Merged

Wagtail 6.2 Support #813

merged 21 commits into from
Aug 22, 2024

Conversation

engineervix
Copy link
Contributor

TBX Support Ticket

This PR adds Wagtail 6.2 Support.

Changes

Other notes

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.92%. Comparing base (cf12512) to head (bf026bc).
Report is 10 commits behind head on main.

Files Patch % Lines
wagtail_localize/views/report.py 80.00% 1 Missing and 1 partial ⚠️
wagtail_localize/wagtail_hooks.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
+ Coverage   92.83%   92.92%   +0.08%     
==========================================
  Files          47       47              
  Lines        4148     4144       -4     
  Branches      605      704      +99     
==========================================
  Hits         3851     3851              
  Misses        176      176              
+ Partials      121      117       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @engineervix This is good work thank you.

`index_results_url_name`, and `index_url_name` are set to support AJAX updates
and utilize the `wagtail.admin.ui.tables` framework.
"""
if WAGTAIL_VERSION < (6, 2):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Loving the code docs 👍

Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this.
Did a first pass review. Will test locally tomorrow

pyproject.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@zerolab zerolab mentioned this pull request Aug 21, 2024
24 tasks
Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @engineervix (and @katdom13)

@zerolab zerolab merged commit 9741735 into wagtail:main Aug 22, 2024
10 checks passed
@hpoul
Copy link
Contributor

hpoul commented Aug 26, 2024

@zerolab Any idea when a new release with this PR is planned? Seems like it missed 1.9.1. Mainly for Django 5.1 compatibility :-) thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants