-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 6.2 Support #813
Wagtail 6.2 Support #813
Conversation
…eldPanel(title) in content_panels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
==========================================
+ Coverage 92.83% 92.92% +0.08%
==========================================
Files 47 47
Lines 4148 4144 -4
Branches 605 704 +99
==========================================
Hits 3851 3851
Misses 176 176
+ Partials 121 117 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @engineervix This is good work thank you.
`index_results_url_name`, and `index_url_name` are set to support AJAX updates | ||
and utilize the `wagtail.admin.ui.tables` framework. | ||
""" | ||
if WAGTAIL_VERSION < (6, 2): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Loving the code docs 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this.
Did a first pass review. Will test locally tomorrow
Wagtail 6.2 supports Django 5.x, as per https://github.com/wagtail/wagtail/blob/37bc8c8c/setup.py#L22
Wagtail 6.0 is no longer supported (https://endoflife.date/wagtail)
- include Django 5.1 - drop Python 3.8
As it reaches EOL on 2024-10-31 https://endoflife.date/python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @engineervix (and @katdom13)
@zerolab Any idea when a new release with this PR is planned? Seems like it missed 1.9.1. Mainly for Django 5.1 compatibility :-) thanks. |
TBX Support Ticket
This PR adds Wagtail 6.2 Support.
Changes
Other notes