-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wagtail 4.2 upgrade #673
Wagtail 4.2 upgrade #673
Conversation
katdom13
commented
Feb 2, 2023
- Update testing to accommodate Wagtail 4.2
cf5f7f0
to
f4d3bae
Compare
Codecov ReportBase: 91.61% // Head: 93.05% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
+ Coverage 91.61% 93.05% +1.43%
==========================================
Files 47 47
Lines 4008 3929 -79
Branches 609 581 -28
==========================================
- Hits 3672 3656 -16
+ Misses 201 161 -40
+ Partials 135 112 -23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d4011e2
to
eeb8e73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more tweaks and we should be there
a59e3bd
to
3d9db3b
Compare
13c2958
to
92f6227
Compare
92f6227
to
f219766
Compare
Revert "Code cleanup" This reverts commit 4262d82. Code cleanup
5ffbfdf
to
8bd6917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taking great shape. Thank you for your effort, @katdom13
Left a number of further cleanup needed, plus the main migration should not be changed.
In additional to that,
https://github.com/wagtail/wagtail-localize/tree/146b4e15bfc50974dddabe424765c3ae85028768/wagtail_localize/static_src/legacy needs to go since it is 2.x, as well as
import LegacyTranslationEditor from '../legacy/editor/components/TranslationEditor'; |
has_legacy_styling
conditional (wagtail-localize/wagtail_localize/static_src/editor/main.tsx
Lines 20 to 22 in 1fc56b0
if (props.has_legacy_styling) { | |
Component = LegacyTranslationEditor; | |
} |
…igration, dropped compat functions
5577e31
to
0efe060
Compare
The latest commit aa2c0c4 updates the workflow to use tox-gh-actions as suggested by Nick Moreton. |