Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting to create draft, not live, pages on translation. #656

Closed
wants to merge 3 commits into from

Conversation

mattlinares
Copy link
Contributor

wagtail_localize/operations.py Outdated Show resolved Hide resolved
@Adrian-Hernando-Noom
Copy link

Any chance this will be merged any time soon? Thank you!

Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test for the setting variations.

See https://github.com/wagtail/wagtail-localize/blob/main/wagtail_localize/tests/test_submit_translations.py#L227-L247 for the current test for submitting the create translation form. Specifically https://github.com/wagtail/wagtail-localize/blob/main/wagtail_localize/tests/test_submit_translations.py#L241-L243 which checks for the published status

wagtail_localize/operations.py Show resolved Hide resolved
@mattlinares
Copy link
Contributor Author

@zerolab Hopefully this test does the job now. Happy to expand on this if you think it needs more coverage. Thanks.

a606f59

zerolab pushed a commit that referenced this pull request Jan 22, 2023
@zerolab
Copy link
Collaborator

zerolab commented Jan 22, 2023

Merged in 7dd4655. Thanks @mattlinares

@zerolab zerolab closed this Jan 22, 2023
zerolab pushed a commit that referenced this pull request Jan 22, 2023
zerolab pushed a commit that referenced this pull request Jan 22, 2023
@mattlinares
Copy link
Contributor Author

Hi @zerolab this didn't actually get merged in the end because of a Flake8 error I think: https://app.circleci.com/pipelines/github/wagtail/wagtail-localize/2049/workflows/e1a85faf-ba5e-4f4b-80ca-5b513c54aca7/jobs/3607

I have fixed that and PR'd again. Hopefully you can merge this successfully now (though it also seems to have failed checks This workflow requires approval from a maintainer. 5 failing checks).

#675

Sorry for the bother!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants