-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting to create draft, not live, pages on translation. #656
Conversation
Any chance this will be merged any time soon? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a test for the setting variations.
See https://github.com/wagtail/wagtail-localize/blob/main/wagtail_localize/tests/test_submit_translations.py#L227-L247 for the current test for submitting the create translation form. Specifically https://github.com/wagtail/wagtail-localize/blob/main/wagtail_localize/tests/test_submit_translations.py#L241-L243 which checks for the published status
Merged in 7dd4655. Thanks @mattlinares |
Hi @zerolab this didn't actually get merged in the end because of a Flake8 error I think: https://app.circleci.com/pipelines/github/wagtail/wagtail-localize/2049/workflows/e1a85faf-ba5e-4f4b-80ca-5b513c54aca7/jobs/3607 I have fixed that and PR'd again. Hopefully you can merge this successfully now (though it also seems to have failed checks Sorry for the bother! |
As per #655
and discussed on Slack: https://wagtailcms.slack.com/archives/CD4S91XF0/p1668602376804759