Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget extraction for choosers in ListBlock #639

Closed
wants to merge 4 commits into from
Closed

Fix widget extraction for choosers in ListBlock #639

wants to merge 4 commits into from

Conversation

tspnn
Copy link
Contributor

@tspnn tspnn commented Oct 17, 2022

Fixes #638

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 91.75% // Head: 91.78% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (6b592ed) compared to base (ffb3a6b).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   91.75%   91.78%   +0.03%     
==========================================
  Files          46       46              
  Lines        3976     3980       +4     
  Branches      602      603       +1     
==========================================
+ Hits         3648     3653       +5     
  Misses        194      194              
+ Partials      134      133       -1     
Impacted Files Coverage Δ
wagtail_localize/views/edit_translation.py 85.32% <75.00%> (+0.23%) ⬆️
wagtail_localize/test/models.py 98.80% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tspnn tspnn requested a review from zerolab October 17, 2022 12:35
@zerolab
Copy link
Collaborator

zerolab commented Oct 17, 2022

This LGTM. Thank you @Spikenn

@zerolab
Copy link
Collaborator

zerolab commented Oct 17, 2022

Will merge and make a patch release in about 3 or so hours (once I'm done with work)

@zerolab
Copy link
Collaborator

zerolab commented Oct 17, 2022

Sorted out the migration and merge in 0e6f02b and parents.

Thank you

@zerolab zerolab closed this Oct 17, 2022
@zerolab
Copy link
Collaborator

zerolab commented Oct 17, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

widget_from_block returns unknown type for ImageChooser/DocumentChooser inside a ListBlock
3 participants