Add method to delete translation data on translatable model deletion #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
force-pushed
the
chore/clean-up-translation-data-on-delete
branch
3 times, most recently
from
400b3d0 to
d777dd8
Compare
zerolab
force-pushed
the
chore/clean-up-translation-data-on-delete
branch
from
d777dd8 to
ced11f7
Compare
tbrlpld
reviewed
Oct 13, 2022
tbrlpld
reviewed
Oct 13, 2022
tbrlpld
reviewed
Oct 13, 2022
zerolab
force-pushed
the
chore/clean-up-translation-data-on-delete
branch
from
ced11f7 to
c563047
Compare
zerolab
force-pushed
the
chore/clean-up-translation-data-on-delete
branch
from
c563047 to
f68ad59
Compare
|
@kaedroho will merge this tomorrow mid-morning, unless I hear otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default behaviour so that it removes related localize data on translatable model deletion, rather than marking the
Translationas disabled.Adds a setting (
WAGTAILLOCALIZE_DISABLE_ON_DELETEto allow for the old behaviour should it be needed.Fixes #402
To-Do: