Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against ManyToOneRel child field without help text or verbose name #620

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Sep 23, 2022

Fixes #284

@zerolab zerolab added this to the 1.3 milestone Sep 23, 2022
@zerolab zerolab marked this pull request as draft September 23, 2022 11:48
@codecov-commenter
Copy link

Codecov Report

Base: 91.80% // Head: 91.80% // No change to project coverage 👍

Coverage data is based on head (9cdc2c6) compared to base (7c8b75d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          46       46           
  Lines        3916     3916           
  Branches      593      593           
=======================================
  Hits         3595     3595           
  Misses        188      188           
  Partials      133      133           
Impacted Files Coverage Δ
wagtail_localize/views/edit_translation.py 84.71% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zerolab zerolab force-pushed the fix/maytoonerel-help-text branch from 9cdc2c6 to 99f8e7d Compare September 23, 2022 16:24
@zerolab zerolab marked this pull request as ready for review September 23, 2022 16:26
@zerolab zerolab requested a review from chris48s September 26, 2022 14:01
@zerolab zerolab merged commit a0b7da5 into main Sep 26, 2022
@zerolab zerolab deleted the fix/maytoonerel-help-text branch October 15, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'ManyToOneRel' object has no attribute 'help_text' when translating FormPage
3 participants