Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestSubmitPageTranslationWithComponents for Wagtail 4 #601

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

gasman
Copy link
Contributor

@gasman gasman commented Aug 18, 2022

The markup for form fields with errors has changed substantially in Wagtail 4, and now there's no straightforward way to assert "an error exists on field X" using a substring match on the HTML. Instead, check the form object directly.

The markup for form fields with errors has changed substantially in Wagtail 4, and now there's no straightforward way to assert "an error exists on field X" using a substring match on the HTML. Instead, check the form object directly.
Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thank you @gasman!

@zerolab zerolab merged commit 8639e36 into wagtail:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants