Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix further Wagtail main failures and tidy up GH Action/Makefile #572

Merged
merged 3 commits into from
May 20, 2022

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented May 20, 2022

This PR:

  • adds a callable for the page revision model (with Wagtail 4.0, that will be wagtailcore.Revision ref: Replace PageRevision with generic Revision model wagtail#8441) -- should fix the nightly test failures
  • updates the test GitHub Action to:
    • cancel previous in-progress jobs for the same branch/PR
    • cache tox
    • use newer action versions from GitHub
  • adds a few more commands to the Makefile

zerolab added 3 commits May 20, 2022 11:29
* cancels olde in-progress jobs for the same branch/PR
* uses newer actions versions
* adds tox caching
@zerolab zerolab force-pushed the chore/catching-up-with-maincore-and-other-adventures branch from 3450625 to 2924c39 Compare May 20, 2022 11:16
@codecov-commenter
Copy link

Codecov Report

Merging #572 (2924c39) into main (7d6278c) will increase coverage by 0.11%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   91.44%   91.55%   +0.11%     
==========================================
  Files          47       47              
  Lines        3894     3898       +4     
  Branches      591      592       +1     
==========================================
+ Hits         3561     3569       +8     
+ Misses        192      186       -6     
- Partials      141      143       +2     
Impacted Files Coverage Δ
wagtail_localize/compat.py 51.85% <50.00%> (-0.33%) ⬇️
wagtail_localize/models.py 95.57% <100.00%> (-0.15%) ⬇️
wagtail_localize/components.py 82.69% <0.00%> (-1.93%) ⬇️
wagtail_localize/views/convert.py 71.62% <0.00%> (+1.35%) ⬆️
wagtail_localize/views/edit_translation.py 85.44% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6278c...2924c39. Read the comment docs.

@zerolab zerolab requested a review from kaedroho May 20, 2022 12:37
Copy link
Contributor

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but aside from that LGTM. If the answer is 'no', just merge it 👍

Makefile Show resolved Hide resolved
@zerolab zerolab merged commit 4716862 into main May 20, 2022
@zerolab zerolab deleted the chore/catching-up-with-maincore-and-other-adventures branch February 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants