Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header styling for Wagtail 3.0 #560

Merged
merged 1 commit into from
May 6, 2022
Merged

Fix header styling for Wagtail 3.0 #560

merged 1 commit into from
May 6, 2022

Conversation

kaedroho
Copy link
Contributor

@kaedroho kaedroho commented Apr 29, 2022 •
edited
Loading

This PR adds back CSS that was removed in Wagtail 3.0 to make the header look as it was before.

I think it'll be simpler to use the old header styling until we drop support for Wagtail 2. What do you think?

Wagtail 2.16

image

Wagtail 3.0 (RC3)

image

zerolab
zerolab approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good intermediary step. Makes the edit interface usable in 3.0, at least.

@zerolab zerolab merged commit dc296dd into main May 6, 2022
@zerolab zerolab deleted the header-styling branch May 6, 2022 14:51
@zerolab zerolab mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerolab zerolab zerolab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaedroho @zerolab