Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support further ListBlock nesting #559

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Apr 28, 2022

ListBlock in StructBlock in StructBlock in ListBlock (and probably a few further levels down the rabbit hole`

Test build: https://zerolab.org/_dumps/wagtail_localize-1.1.2rc1-py3-none-any.whl

@zerolab zerolab requested a review from kaedroho April 28, 2022 08:16
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #559 (b00a671) into main (eb825ed) will decrease coverage by 0.05%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   90.88%   90.82%   -0.06%     
==========================================
  Files          37       37              
  Lines        3303     3315      +12     
  Branches      537      539       +2     
==========================================
+ Hits         3002     3011       +9     
- Misses        176      179       +3     
  Partials      125      125              
Impacted Files Coverage Δ
wagtail_localize/segments/extract.py 86.92% <55.55%> (-1.35%) ⬇️
wagtail_localize/test/models.py 97.67% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb825ed...b00a671. Read the comment docs.

@zerolab zerolab requested review from chris48s and removed request for kaedroho April 28, 2022 10:29
Copy link
Contributor

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the netlify build failures are unrelated to these functional changes?

wagtail_localize/segments/extract.py Outdated Show resolved Hide resolved
@zerolab zerolab force-pushed the chore/further-listblock-nesting branch from 3e49cf7 to b00a671 Compare April 28, 2022 13:06
@zerolab zerolab merged commit 6cb9875 into main Apr 28, 2022
@zerolab zerolab deleted the chore/further-listblock-nesting branch April 28, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants