Convert to alias #515
Convert to alias #515
Conversation
Only applies to translated pages
zerolab
force-pushed
the
feature/translated-page-back-to-alias
branch
from
a8c9161 to
25ffc81
Compare
wagtail_localize/templates/wagtail_localize/admin/confirm_convert_to_alias.html
Outdated
Show resolved
Hide resolved
wagtail_localize/views/convert.py
Outdated
| next_url = get_valid_next_url_from_request(request) | ||
|
|
||
| if request.method == "POST": | ||
| page.alias_of_id = source_page_id |
There was a problem hiding this comment.
Should we synchronise the content of the source page at this point?
There was a problem hiding this comment.
probably worth it, will check
There was a problem hiding this comment.
The consensus is that ye, we should synchronise with the source page at this point
There was a problem hiding this comment.
tl;dr
Tried with Translation.save_target() but that is very much dependent on the translatable_fields definition or lack thereof.
Resorted to a tweaked copy of Page.update_alias
There was a problem hiding this comment.
Thanks, do you think we could get those tweaks rolled back in to Wagtail core?
I'm happy with this change anyhow
Codecov Report
@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 91.72% 91.56% -0.17%
==========================================
Files 36 37 +1
Lines 3081 3200 +119
Branches 494 513 +19
==========================================
+ Hits 2826 2930 +104
- Misses 145 154 +9
- Partials 110 116 +6
Continue to review full report at Codecov.
|
zerolab
force-pushed
the
feature/translated-page-back-to-alias
branch
from
7d97ecd to
ae28a5b
Compare
wagtail_localize/static_src/editor/components/TranslationEditor/footer.tsx
Show resolved
Hide resolved
This PR fixes #466 by adding functionality to convert translations (translated pages, to be more exact) into aliases
It also adds a
wagtail_localize.convert_to_aliasPageLogEntry action, and its own icon.Demo: https://youtu.be/N6iVvq4sqjU