Handle text field clearing when syncing #495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
tl;dr - we mark text fields and
StreamField
s asTranslateableField
, but only flagStreamField
s as needing syncing. When the value is removed, there is nothing to tellTranslation.create_or_update_translation()
that this has happened.Translation._get_segments_for_translation()
only return translateable fields that have values in them, so nothing will happen viaingest_segments