Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle configurable comments relation (Wagtail 2.15 fix) #468

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

gasman
Copy link
Contributor

@gasman gasman commented Oct 14, 2021

The 'comments' relation on Page will be renamed to 'wagtail_admin_comments' in Wagtail 2.15, as per wagtail/wagtail#7591, and 2.13.5 / 2.14.2 will allow developers to 'opt in' to the new name to prevent conflicts with third-party packages that also use the name 'comments' (wagtail/wagtail#7600 / wagtail/wagtail#7601). We therefore need to recognise the relation name in use, rather than hard-coding 'comments'.

The 'comments' relation on Page will be renamed to 'wagtail_admin_comments' in Wagtail 2.15, as per wagtail/wagtail#7591, and 2.13.5 / 2.14.2 will allow developers to 'opt in' to the new name to prevent conflicts with third-party packages that also use the name 'comments' (wagtail/wagtail#7600 / wagtail/wagtail#7601). We therefore need to recognise the relation name in use, rather than hard-coding 'comments'.
@gasman gasman requested a review from kaedroho October 14, 2021 12:23
@codecov-commenter
Copy link

Codecov Report

Merging #468 (ad5f385) into main (8ee52c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   93.13%   93.14%           
=======================================
  Files          35       35           
  Lines        2840     2844    +4     
  Branches      447      447           
=======================================
+ Hits         2645     2649    +4     
  Misses         99       99           
  Partials       96       96           
Impacted Files Coverage Δ
wagtail_localize/fields.py 92.72% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee52c8...ad5f385. Read the comment docs.

@kaedroho
Copy link
Contributor

Thanks for fixing!

@kaedroho kaedroho merged commit 94b79fc into wagtail:main Oct 15, 2021
kaedroho added a commit that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants