Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement overridable parameter on SynchronizedField #438

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

kaedroho
Copy link
Contributor

Fixes #436

@kaedroho kaedroho force-pushed the non-overridable-synchronisedfield branch from 37c0acb to 0b615d4 Compare July 26, 2021 10:16
@codecov-commenter
Copy link

Codecov Report

Merging #438 (0b615d4) into main (f588005) will increase coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   93.07%   93.10%   +0.02%     
==========================================
  Files          35       35              
  Lines        2802     2812      +10     
  Branches      445      445              
==========================================
+ Hits         2608     2618      +10     
  Misses         98       98              
  Partials       96       96              
Impacted Files Coverage Δ
wagtail_localize/segments/extract.py 87.59% <33.33%> (+0.19%) ⬆️
wagtail_localize/fields.py 92.45% <100.00%> (+0.53%) ⬆️
wagtail_localize/test/models.py 97.60% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f588005...0b615d4. Read the comment docs.

@kaedroho kaedroho merged commit b88fd86 into main Aug 3, 2021
@kaedroho kaedroho deleted the non-overridable-synchronisedfield branch August 3, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

non-overridable SynchronizedFields
3 participants