Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update tooling #84

Merged
merged 25 commits into from
Feb 19, 2024
Merged

Chore/update tooling #84

merged 25 commits into from
Feb 19, 2024

Conversation

jams2
Copy link
Contributor

@jams2 jams2 commented Feb 15, 2024

No description provided.

ruff.toml Outdated Show resolved Hide resolved
@jams2 jams2 mentioned this pull request Feb 18, 2024
Copy link
Contributor Author

@jams2 jams2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerolab are you up for giving this a review?

The code and formatting changes are from ruff.

.github/workflows/python-tox.yml Show resolved Hide resolved
CHANGES Show resolved Hide resolved
MANIFEST.in Show resolved Hide resolved
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions and questions

ruff.toml Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
tests/settings.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Co-authored-by: Dan Braghiș <[email protected]>
@jams2 jams2 mentioned this pull request Feb 18, 2024
5 tasks
@jams2 jams2 marked this pull request as ready for review February 18, 2024 22:55
@jams2 jams2 requested a review from zerolab February 18, 2024 22:55
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jams2 jams2 merged commit 6109d79 into wagtail:main Feb 19, 2024
5 checks passed
@jams2 jams2 deleted the chore/update-tooling branch February 19, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants