Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rst-content class to body #136

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Conversation

PaarthAgarwal
Copy link
Member

I have added rst-content class to the main body. I couldn't test this change as I mentioned in #20 (comment) but I believe it should fix #131.

@PaarthAgarwal
Copy link
Member Author

Throwing the same error as I got while building docs. I believe it's happening because jinja2 has replaced contextfunction with pass_context.
Reference: https://stackoverflow.com/a/71634495

@PaarthAgarwal
Copy link
Member Author

I found a PR that replaces the deprecated contextfunction with pass_context wagtail/wagtail#8203.

@lb- lb- force-pushed the add_rst_style branch from 86fbd2a to 1b2451d Compare April 3, 2022 10:38
Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great @PaarthAgarwal
the build issue should be resolved via this PR once merged #142

I checked your change locally and this does the job nicely, thank you.

@lb- lb- merged commit 506c1b4 into wagtail:main Apr 3, 2022
@PaarthAgarwal
Copy link
Member Author

Thanks, @lb-. Please see #20 (comment). I am unable to build docs for testing. Will this also resolve with #142?

@lb-
Copy link
Member

lb- commented Apr 4, 2022

Hey @PaarthAgarwal - hopefully the changes in 142 will help but if you get stuck maybe reach out on #support in slack and myself or someone might be able to help (feel free to ping me in Slack)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rst-content styles are not being used
2 participants