Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard to read syntax highlighting #147

Closed
tbrlpld opened this issue Apr 5, 2022 · 3 comments · Fixed by #151
Closed

Hard to read syntax highlighting #147

tbrlpld opened this issue Apr 5, 2022 · 3 comments · Fixed by #151

Comments

@tbrlpld
Copy link
Collaborator

tbrlpld commented Apr 5, 2022

Screen Shot 2022-04-05 at 2 58 10 PM
@lb-
Copy link
Member

lb- commented Apr 6, 2022

Hmm - this may have happened when we added the .rst root class
#136

Maybe we need to revise or remove this section?

https://github.com/wagtail/sphinx_wagtail_theme/blob/main/sass/_component_rst.scss#L23-L49

@tbrlpld
Copy link
Collaborator Author

tbrlpld commented Apr 6, 2022 •
edited
Loading

Yea, why was that changed anyhow? The previous syntax highlights that are currently active in the Wagtail docs look fine to me.

@lb-
Copy link
Member

lb- commented Apr 6, 2022 •
edited
Loading

I have a fix I think, we have to set pygments_style to None we have now got our own pygments styles and the Sphinx ones are not required.

I think this happened as part of the update to the latest Sphinx version and not the rst root class.

Update - yep pygments.css is not included in the current production wagtail docs, but it is being included in our main branch depoyment.

lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this issue Apr 6, 2022
disable pygments theme
d6f1b70 
- see sphinx_wagtail_theme/theme.conf (already disabled there)
- this project has its own pygments styling to suit the code block colours
- see https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-pygments_style
- fixes wagtail#147
@lb- lb- mentioned this issue Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix - disable pygments theme to only use custom code block styling lb-/sphinx_wagtail_theme
2 participants
@lb- @tbrlpld