Use <main> element to match role=main area of body content #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Ok, I'll publish then. Feel free to merge unless anyone objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #113 . What do you think of this instead @Scotchester ?
Tested both before and after this change in various browsers and using the Windows narrator. Does not seem to be any visual or audible change.
I think use of these new HTML 5 elements seems to be splitting hairs in some places (i.e. difference between a
<main>and an<article>element). However from researching MDN this current structure seems to be perfectly "legal" and make sense. Main is used for the actual page content (if you were to have a "skip to main content" button, it would jump here). Main can also contain headings, sections, paragraphs, etc.Following this logic... sphinx looks for
role="main"on page elements to determine what to index in its JavaScript-based search. So I don't think we'd want the breadcrumbs and "Edit on GitHub" buttons being indexed.