Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests against Wagtail 4.x #49

Closed
wants to merge 6 commits into from

Conversation

gasman
Copy link
Contributor

@gasman gasman commented Oct 19, 2022

No description provided.

As of wagtail/wagtail@265fb30, get_latest_revision is a field access on the local model rather than a live query, so it needs to be done on a newly-retrieved instance
Copy link
Member

@Stormheg Stormheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks sensible to me.

@oladhari
Copy link

oladhari commented Jan 4, 2023

any progress to merge this PR and create new release?

Copy link

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gasman
Copy link
Contributor Author

gasman commented Jan 4, 2023

Merged in 2dd933d

@gasman gasman closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants