Skip to content

Commit

Permalink
fix: lerna scopes not working due to missing lerna dependency
Browse files Browse the repository at this point in the history
`@commitlint/config-lerna-scopes` package depends on lerna but doesn't have `lerna` listed in its dependencies, so the action was failing. Since this action doesn't run in the repo's context, we need to install lerna as a dependency to make it work.
  • Loading branch information
wagoid committed Oct 18, 2019
1 parent 2c42093 commit 99b068a
Show file tree
Hide file tree
Showing 5 changed files with 4,813 additions and 213 deletions.
4 changes: 4 additions & 0 deletions .commitlintrc-with-lerna-scopes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
extends:
- '@commitlint/config-conventional'
- '@commitlint/config-lerna-scopes'
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
node_modules
.commitlintrc.yml
commitlint.config.js
.commitlintrc-with-lerna-scopes
action.yml
.github
CHANGELOG.md
10 changes: 10 additions & 0 deletions .github/workflows/commitlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,13 @@ jobs:
- uses: ./
with:
configFile: './.commitlintrc.yml'
commitlint-with-lerna-scopes:
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v1
- run: sed -i -E "s/([']docker:.+)/Dockerfile/" ./action.yml
- uses: ./
with:
configFile: './.commitlintrc-with-lerna-scopes.yml'
Loading

0 comments on commit 99b068a

Please sign in to comment.