Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with Node 12 #61

Closed
mcollina opened this issue Dec 15, 2018 · 1 comment
Closed

Incompatibility with Node 12 #61

mcollina opened this issue Dec 15, 2018 · 1 comment

Comments

@mcollina
Copy link

microtime will not compile on Node.js 12 because of the usage of some V8 APIs that are currently deprecated and will be removed in the next release. Would you mind updating this module to the latest nan, or land #57?

We are removing this module from CITGM until this is solved: nodejs/citgm#654
@mcollina mcollina mentioned this issue Dec 15, 2018
Closed
9 tasks
@targos targos mentioned this issue Dec 15, 2018
Closed
@wadey
Copy link
Owner

wadey commented Jan 26, 2019

microtime 2.1.9 released with latest nan.

@wadey wadey closed this as completed Jan 26, 2019
wadey added a commit to wadey/citgm that referenced this issue Jan 31, 2019
@wadey
don't skip 12 for microtime
44b1e73 
Microtime was updated to the latest version of nan, and a n-api version will be released soon.

wadey/node-microtime#61
@wadey wadey mentioned this issue Jan 31, 2019
Merged
BridgeAR pushed a commit to nodejs/citgm that referenced this issue Feb 16, 2019
@wadey @BridgeAR
don't skip 12 for microtime (#678)
9cf19c5 
Microtime was updated to the latest version of nan, and an n-api version will be released soon.

wadey/node-microtime#61
@TSFoster TSFoster mentioned this issue May 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wadey @mcollina