Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable onion service #372

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Add option to disable onion service #372

merged 4 commits into from
Apr 17, 2023

Conversation

waybackarchiver
Copy link
Contributor

Description

To disable the onion service, set the WAYBACK_ONION_DISABLED environment variable. This feature will be supported in the next release or in the latest commit after this pull request is merged.

Close #370

Checklist

@waybackarchiver waybackarchiver added enhancement New feature or request go Pull requests that update Go code labels Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 64.51% and no project coverage change.

Comparison is base (5fe18b7) 47.19% compared to head (d67c2d7) 47.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   47.19%   47.19%           
=======================================
  Files          58       58           
  Lines        5130     5136    +6     
=======================================
+ Hits         2421     2424    +3     
- Misses       2449     2450    +1     
- Partials      260      262    +2     
Impacted Files Coverage Δ
service/httpd/httpd.go 72.88% <0.00%> (ø)
service/httpd/onion.go 6.15% <10.00%> (ø)
config/options.go 93.71% <100.00%> (+0.01%) ⬆️
config/parser.go 91.84% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver changed the title Improve onion service Add option to disable onion service Apr 17, 2023
@waybackarchiver waybackarchiver merged commit a835a79 into main Apr 17, 2023
@waybackarchiver waybackarchiver deleted the improve-httpd branch April 17, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starts a Tor hidden service regardless of flags or Config options.
1 participant