Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always parse config file under daemon mode #271

Merged
merged 3 commits into from
Dec 28, 2022
Merged

Conversation

waybackarchiver
Copy link
Contributor

Description


Issue Ticket Number

Fixes #(issue_number)


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@waybackarchiver waybackarchiver added enhancement New feature or request go Pull requests that update Go code labels Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 45.53% // Head: 45.49% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (6a97547) compared to base (e5d4b03).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   45.53%   45.49%   -0.04%     
==========================================
  Files          41       41              
  Lines        5001     5001              
==========================================
- Hits         2277     2275       -2     
- Misses       2467     2469       +2     
  Partials      257      257              
Impacted Files Coverage Δ
service/slack/slack.go 4.89% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waybackarchiver waybackarchiver marked this pull request as ready for review December 13, 2022 08:33
@waybackarchiver waybackarchiver merged commit 061c62b into main Dec 28, 2022
@waybackarchiver waybackarchiver deleted the fix-config-file branch December 28, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant