Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: handle Style/Explode values for Query parameters. #28

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

wI2L
Copy link
Owner

@wI2L wI2L commented Jan 29, 2019

depends on loopfz/gadgeto#58

@wI2L wI2L added the enhancement New feature or request label Jan 29, 2019
@wI2L wI2L self-assigned this Jan 29, 2019
@wI2L wI2L requested a review from Inozuma January 29, 2019 14:05
@wI2L wI2L force-pushed the querystring-explode branch 3 times, most recently from d77615d to 8d68e1e Compare January 29, 2019 14:16
@wI2L wI2L removed their assignment Jan 29, 2019
@wI2L wI2L force-pushed the querystring-explode branch 5 times, most recently from 58ee723 to 330bf5b Compare February 11, 2019 15:50
@wI2L wI2L force-pushed the querystring-explode branch from 330bf5b to 853c81e Compare February 11, 2019 16:11
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #28 into master will decrease coverage by 0.3%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   97.14%   96.84%   -0.31%     
==========================================
  Files           7        7              
  Lines         912      919       +7     
==========================================
+ Hits          886      890       +4     
- Misses         14       16       +2     
- Partials       12       13       +1
Impacted Files Coverage Δ
openapi/spec.go 100% <ø> (ø) ⬆️
openapi/generator.go 95.27% <57.14%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b46127...853c81e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #28 into master will decrease coverage by 0.3%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   97.14%   96.84%   -0.31%     
==========================================
  Files           7        7              
  Lines         912      919       +7     
==========================================
+ Hits          886      890       +4     
- Misses         14       16       +2     
- Partials       12       13       +1
Impacted Files Coverage Δ
openapi/spec.go 100% <ø> (ø) ⬆️
openapi/generator.go 95.27% <57.14%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b46127...853c81e. Read the comment docs.

@wI2L wI2L merged commit e4259a1 into master Feb 11, 2019
@wI2L wI2L deleted the querystring-explode branch February 11, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant