Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - introduce dynamic Recv/Sent Exchange Types #95

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

w7sst
Copy link
Owner

@w7sst w7sst commented Nov 8, 2022

Fixes #94 - introduce dynamic Received and Sent Exchange Types. See description in Issue #94 .

@w7sst w7sst requested review from f6fvy, n2ic and ct7aup November 8, 2022 08:01
@w7sst w7sst self-assigned this Nov 8, 2022
@w7sst w7sst linked an issue Nov 8, 2022 that may be closed by this pull request
@w7sst w7sst requested a review from tekenny November 10, 2022 15:24
@w7sst
Copy link
Owner Author

w7sst commented Nov 10, 2022

@tekenny
Hi Tom, I will merge this tonight, but wanted to give you an chance to see this latest refactoring change.

Copy link
Collaborator

@tekenny tekenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the changes and I don't see any concerns but I am new to the project...

@w7sst w7sst merged commit 2c2c74f into main Nov 11, 2022
@w7sst w7sst deleted the 94-refactor-introduce-sent-and-received-exchange-types branch November 11, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor - introduce Sent and Received Exchange types
4 participants