DxStation now sends 'R' after callsign correction #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
w7sst
commented
Oct 11, 2024
w7sst
commented
- this problem was introduced in 1.85
- Note: When MorePatience was introduced in May 2024, a bug (Issue Do not get an R from dx station after correcting a bad call #370) was introduced causing the DxStation to not send an 'R' after the user corrected a callsign. The case involved the user sending a corrected callsign using the Enter key while leaving the exchange fields blank (user sends ' ?'. In this case, the DxOperator.MsgReceived function would call MorePatience for the '?' and the Patience value was set to 4. This caused DxOperator.GetReply() to send the wrong response: DxOperator.GetReply(osNeedEnd, Patience=5) --> 'R ' DxOperator.GetReply(osNeedEnd, Patience=4) --> '' To fix this problem, MorePatience will maintain an existing Patience value of 5 (FULL_PATIENCE) and not set it to 4. Resolved in October 2024.
- Issue Do not get an R from dx station after correcting a bad call #370
- this problem was introduced in 1.85 - Note: When MorePatience was introduced in May 2024, a bug (Issue #370) was introduced causing the DxStation to not send an 'R' after the user corrected a callsign. The case involved the user sending a corrected callsign using the Enter key while leaving the exchange fields blank (user sends '<his incorrect call> ?'. In this case, the DxOperator.MsgReceived function would call MorePatience for the '?' and the Patience value was set to 4. This caused DxOperator.GetReply() to send the wrong response: DxOperator.GetReply(osNeedEnd, Patience=5) --> 'R <HisCall>' DxOperator.GetReply(osNeedEnd, Patience=4) --> '<HisCall>' To fix this problem, MorePatience will maintain an existing Patience value of 5 (FULL_PATIENCE) and not set it to 4. Resolved in October 2024.
1 task
w7sst
deleted the
370-do-not-get-an-r-from-dx-station-after-correcting-a-bad-call
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.