Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARRL SS - display parsed exchange summary (#357) #363

Merged
merged 3 commits into from
Sep 27, 2024
Merged

ARRL SS - display parsed exchange summary (#357) #363

merged 3 commits into from
Sep 27, 2024

Conversation

w7sst
Copy link
Owner

@w7sst w7sst commented Sep 25, 2024

Cleanup error/status reporting code for ARRL Sweepstakes

- clear exchange error after each QSO
- improve status bar handling allowing exchange summary to be displayed
- remove 'Call' from exchange entry heading for Arrl SS.
- Add ShowExchangeSummaryInStatusBar to MorseRunner.ini file
- fix problem where F5 (HisCall) was not sending the previous QSO's callsign.

@w7sst
Fix issue where SS Exchange field is resize multiple times
d754d7b 
- This was occuring after user enters an invalid exchange
  in the My Exchange field during setup of ARRL SS Contest.
@w7sst
Cleanup error/status reporting code for ARRL Sweepstakes
33526ac 
- clear exchange error after each QSO
- improve status bar handling allowing exchange summary to be displayed
- remove 'Call' from exchange entry heading for Arrl SS.
- Add ShowExchangeSummaryInStatusBar to MorseRunner.ini file
- fix problem where F5 (HisCall) was not sending the previous QSO's callsign.
@w7sst w7sst requested review from f6fvy, scotthibbs and K6OK September 25, 2024 01:15
@w7sst w7sst self-assigned this Sep 25, 2024
@w7sst w7sst linked an issue Sep 25, 2024 that may be closed by this pull request
ARRL SS - Display parsed exchange summary in Exchange Caption after each keystroke #357
Closed
4 tasks
@w7sst
Display SS Exchange summary in Label above entry field
be9095e 
- switched back to summary display in the label
- changed .INI switch to ShowExchangeSummary
- updated Readme.txt
- Summary in Status Bar is not documented in Readme.txt file
  (we may end up removing this from the code)
- Part of Issue #357
@w7sst
Copy link
Owner Author

w7sst commented Sep 27, 2024 •
edited
Loading

@K6OK

Hi Jim, this is the changes for moving the exchange summary back above the Entry field (using the label as in rc3).

I also changed the MorseRunner.ini file to use:

      By default, this information is displayed above the exchange entry field.
      If desired, the exchange summary can be turned off. This is controlled by
      setting the following keyword in the MorseRunner.ini file:
        [Settings]
        ShowExchangeSummary=N
      Valid values for N:
        0 - Off
        1 - Display summary in label above entry field (default)

Currently, the Status Bar choice (2) is not documented and the code is still in place. We may remove this in the future.

@scotthibbs

K6OK
K6OK approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@K6OK K6OK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 👍

@w7sst w7sst merged commit 19c3667 into main Sep 27, 2024
@w7sst w7sst deleted the 357-arrl-ss-display-parsed-exchange-summary branch September 27, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K6OK K6OK K6OK approved these changes

@f6fvy f6fvy Awaiting requested review from f6fvy

@scotthibbs scotthibbs Awaiting requested review from scotthibbs

Assignees

@w7sst w7sst

Labels
None yet
Projects
None yet
Milestone
v1.85 - ARRL Sweepstakes Contest
Development

Successfully merging this pull request may close these issues.

ARRL SS - Display parsed exchange summary in Exchange Caption after each keystroke
2 participants
@w7sst @K6OK