Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARRL SS - display missing or invalid exchange when incomplete exchange #356

Conversation

w7sst
Copy link
Owner

@w7sst w7sst commented Sep 21, 2024

ARRL SS - Display missing/invalid exchange error when missing

  • When exchange contains missing or invalid elements, display an
    error message before sending '?' to notify user of what information
    is needed.
  • Improve exchange error message processing
  • Report callsign length error before sending 'TU'
  • display '?' for missing exchange fields in Log report
  • Fixes Issue ARRL SS - display missing/invalid exchange when incomplete #352

Minor Changes

  • fix crash when missing numeric exchange
  • minor change to SSExchParserTest unit test
  • remove assertion in release mode

- display '?' for missing exchange fields in ARRL SS.
- this helps prevent sending TU before an error message
- When exchange contains missing or invalid elements, display an
  error message before sending '?' to notify user of what information
  is needed.
- Improve exchange error message processing
- Report callsign length error before sending 'TU'
- display '?' for missing exchange fields in Log report
- Fixes Issue #352

Minor Changes
- fix crash when missing numeric exchange
- minor change to SSExchParserTest unit test
- remove assertion in release mode
@w7sst w7sst requested review from f6fvy, scotthibbs and K6OK September 21, 2024 00:27
@w7sst w7sst self-assigned this Sep 21, 2024
Copy link
Collaborator

@K6OK K6OK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 OK

@w7sst w7sst merged commit cc25ba2 into 354-do-not-send-repeated-long-exchanges-in-arrl-ss-contest Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants