Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

324 refactor contest specific logging code #325

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

w7sst
Copy link
Owner

@w7sst w7sst commented Jun 25, 2024

This will merge two refactoring steps:

  1. refactor - Add TContest.ValidateEnteredQsoData
  • move code from from TLog to TContest.ValidateEnteredQsoData
  • allows derived contests to implement special behaviors (e.g ARRL Sweepstakes).
  1. refactor - Add TContest.SaveEnteredExchToQso
  • moves code from Log.pas into Contest.pas
  • allows contest-specific exchange information to be handled by derived contests (e.g. ARRL Sweepstakes).

w7sst added 2 commits June 25, 2024 00:35
- move code from from TLog to TContest.ValidateEnteredQsoData
- allows derived contests to implement special behaviors (e.g ARRL
  Sweepstakes).
- moves code from Log.pas into Contest.pas
- allows contest-specific exchange information to be handled
  by derived contests (e.g. ARRL Sweepstakes).
@w7sst w7sst requested review from f6fvy, jr8ppg and K6OK June 25, 2024 07:45
@w7sst w7sst self-assigned this Jun 25, 2024
@w7sst w7sst linked an issue Jun 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@K6OK K6OK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w7sst w7sst merged commit 1c349a1 into main Jun 25, 2024
@w7sst w7sst deleted the 324-refactor-contest-specific-logging-code branch June 25, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor contest-specific logging code
2 participants